Comments on: Implementation Patterns emerging

By: eno

eno — Fri, 28 Dec 2007 11:58:56 +0000

I like that, this last one is quite expressive…

By: Alexander Lang

Alexander Lang — Thu, 27 Dec 2007 17:07:13 +0000

Nice idea, although I think this gets close to overengineering, but that’s just my personal taste. The problem with this is that in the meantime we have changed the keys in the hash to regular expressions and now using method names would not work anymore. What we could do now is to use blocks again instead of methods:

class Renderers renderer /video\.google\.(de|com)/ do |url| "video.google.com/${url}" end end

This should probably build up another Hash again but then we surely end up with overengineered code. But expressive. Maybe.

(any suggestions for comment preview/code plugins for wordpress?)

By: eno

eno — Thu, 27 Dec 2007 12:28:27 +0000

Having at least one way to insert actual code here and/or some kind of preview: *that* would be great. I would even trade in smileys

By: eno

eno — Thu, 27 Dec 2007 12:26:57 +0000

Ruby offers you a more elegant way of doing this. Remember: an object is more or less a hash matching ids to Proces. So your code could be

class Video class Renderers def self.youtube(url) "player.youtube.com/#{url}" end


    def self.vimeo(url)

      "vimdeo.com/player/#{url}/1"

    end

  end
  def html

    renderers = self.class.Renderers

    provider = renderers.public_methods.

      find { |met| @url.include?(met)}

renderers.send provider, @url end end

2 lines less, no ugly lambdas, no Proc object (which makes that thing faster), Ruby class magic still possible etc.

You could even embed the actual renderers into a module which you would then mix into the Video class: no need to pass url any longer

BTW: It appears your code iterates over *all* renderers, not only over the first one.

See you @ CCC?